jjohannes commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2003199821
########## log4j-samples-gradle-metadata/gradlew: ########## @@ -0,0 +1,251 @@ +#!/bin/sh Review Comment: Yes, that would be the drawback. Not sure how important that is for these example projects if they are mainly used for integration testing (?). What we can do as compromise is to move the wrapper to the root of the repo. And configure the action to use that. A user would then need to use a relative path `../gradlew` from inside the sample folder. And IntelliJ won't find the wrapper/version when you open one of the sample projects. But that's maybe acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
