On Fri, Apr 21, 2006 at 11:27:01AM +1000, herbert wrote: > On Thu, Apr 20, 2006 at 03:36:57PM -0700, Michael Chan wrote: > > > > If we're in tg3_close() and the reset task isn't running yet, tg3_close > > () will proceed. However, when the reset task finally runs, it will see > > that netif_running() is zero and will just return. > > Yes you're absolutely right.
Actually, what if the tg3_close is followed by a tg3_open? That could produce a spurious reset which I suppose isn't that bad. Also if the module is unloaded bad things will happen as well. So I still don't feel too comfortable about leaving it scheduled after a close. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
