On Thu, Apr 20, 2006 at 05:35:00PM +0000, [EMAIL PROTECTED] wrote: > > If the e1000_tx_timeout_task were running concurrently with e1000_down, it > seems that they could both attempt to kfree_skb concurrently when running > e1000_unmap_and_free_tx_resource. I googled around to find mention of this > anywhere with no luck. Has this been discussed already?
Yes that's definitely buggy. There needs to be some form of synchronisation as the TG3 driver does. However, to be frank I'm not too fond of what the TG3 driver does either. Is there no better way than an msleep loop? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
