On Fri, Apr 21, 2006 at 09:36:31AM +1000, herbert wrote: > > Yes that's definitely buggy. There needs to be some form of > synchronisation as the TG3 driver does. However, to be frank > I'm not too fond of what the TG3 driver does either. Is there > no better way than an msleep loop?
Actually TG3 is buggy too. If the reset task is scheduled but isn't running yet there is no synchronisation here to prevent the reset task from running after tg3_close releases the tp lock. It needs to kill the reset task and make sure it doesn't get rescheduled by someone else. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
