Michael Chan <[EMAIL PROTECTED]> wrote: > > In tg3_remove_one(), we call flush_scheduled_work() in case the > reset_task is still pending. Here, it is safe to call
Great. > flush_scheduled_work() because we're not holding the rtnl. Again, when Hmm doing a quick grep seems to indicate that quite a number of drivers do this in netdev->close or other callbacks under RTNL. This means that they're all vulnerable to the linkwatch deadlock that you alluded to. Rather than dealing with this individually in each driver perhaps we should come up with a more centralised solution? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
