On Fri, 2006-04-21 at 11:33 +1000, Herbert Xu wrote: > Actually, what if the tg3_close is followed by a tg3_open? That could > produce a spurious reset which I suppose isn't that bad.
Yes, an extra reset. And yes, it isn't too bad. > Also if the > module is unloaded bad things will happen as well. In tg3_remove_one(), we call flush_scheduled_work() in case the reset_task is still pending. Here, it is safe to call flush_scheduled_work() because we're not holding the rtnl. Again, when it runs, nothing bad will happen because it will see netif_running() == 0. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
