On Tue, 10 Mar 2026 15:22:51 GMT, Jaikiran Pai <[email protected]> wrote:

>> Can I please get a review of this test-only change which proposes to use 
>> "othervm" for some of these tests that configure java.util.logging logger 
>> handlers?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8379477 some of these test 
>> definitions don't explicitly require a othervm and thus can interfere with 
>> one another when configuring logging handlers (for the same logger). The 
>> tests themselves don't seem to do anything useful with those loggers or 
>> logging handlers, so the logging configuration could infact be completely 
>> removed. But after discussing about it, we decided to just switch them over 
>> to othervm for now and also use ConsoleHandler in all these tests.
>> 
>> tier testing completed successfully with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add comment explaining othervm usage

@jaikiran, LGTM. Thanks so much for the changes. 🙇

-------------

Marked as reviewed by vyazici (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30158#pullrequestreview-3924951659

Reply via email to