On Tue, 10 Mar 2026 09:44:18 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this test-only change which proposes to use > "othervm" for some of these tests that configure java.util.logging logger > handlers? > > As noted in https://bugs.openjdk.org/browse/JDK-8379477 some of these test > definitions don't explicitly require a othervm and thus can interfere with > one another when configuring logging handlers (for the same logger). The > tests themselves don't seem to do anything useful with those loggers or > logging handlers, so the logging configuration could infact be completely > removed. But after discussing about it, we decided to just switch them over > to othervm for now and also use ConsoleHandler in all these tests. > > tier testing completed successfully with this change. test/jdk/com/sun/net/httpserver/bugs/ExceptionKeepAlive.java line 41: > 39: import java.util.logging.Logger; > 40: import java.util.logging.SimpleFormatter; > 41: import java.util.logging.StreamHandler; Are these imports still needed? test/jdk/com/sun/net/httpserver/bugs/ExceptionKeepAlive.java line 59: > 57: > 58: private static void setupLogging() { > 59: final Handler handler = new ConsoleHandler(); Suggestion: final ConsoleHandler handler = new ConsoleHandler(); handler.setOutputStream(System.out); test/jdk/com/sun/net/httpserver/bugs/FixedLengthInputStream.java line 93: > 91: > 92: private static void setupLogging() { > 93: final ConsoleHandler handler = new ConsoleHandler(); Suggestion: final ConsoleHandler handler = new ConsoleHandler(); handler.setOutputStream(System.out); test/jdk/com/sun/net/httpserver/bugs/HandlerConnectionClose.java line 344: > 342: > 343: private static void setupLogging() { > 344: final Handler handler = new ConsoleHandler(); Suggestion: final ConsoleHandler handler = new ConsoleHandler(); handler.setOutputStream(System.out); test/jdk/com/sun/net/httpserver/bugs/HeadKeepAlive.java line 58: > 56: > 57: private static void setupLogging() { > 58: final Handler handler = new ConsoleHandler(); Suggestion: final ConsoleHandler handler = new ConsoleHandler(); handler.setOutputStream(System.out); test/jdk/com/sun/net/httpserver/bugs/ZeroLengthOutputStream.java line 84: > 82: > 83: private static void setupLogging() { > 84: final Handler handler = new ConsoleHandler(); Suggestion: final ConsoleHandler handler = new ConsoleHandler(); handler.setOutputStream(System.out); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912145449 PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912180581 PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912193712 PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912202903 PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912212471 PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912220948
