On Tue, 10 Mar 2026 15:01:02 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/com/sun/net/httpserver/bugs/ExceptionKeepAlive.java line 59:
>>
>>> 57:
>>> 58: private static void setupLogging() {
>>> 59: final Handler handler = new ConsoleHandler();
>>
>> Suggestion:
>>
>> final ConsoleHandler handler = new ConsoleHandler();
>> handler.setOutputStream(System.out);
>
> Hello Daniel, `ConsoleHandler` doesn't have a (public) method to set the
> output stream (i.e. there's no setOutputStream(...)). I decided it wasn't
> worth it to create a subclass of ConsoleHandler in these tests just to
> override and use System.out. As far as I can see these log messages are
> merely for debugging.
>
> Do you suggest I create a custom subclass of ConsoleHandler in these tests?
Argh. darn. the method is `protected` - I thought it was `public`. Unless any
of these tests attempt to process System.out then I guess having the debug on
System.err should work as well. Forget those suggestions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2913849541
