On Tue, 10 Mar 2026 14:32:05 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused imports from tests
>
> test/jdk/com/sun/net/httpserver/bugs/ExceptionKeepAlive.java line 59:
>
>> 57:
>> 58: private static void setupLogging() {
>> 59: final Handler handler = new ConsoleHandler();
>
> Suggestion:
>
> final ConsoleHandler handler = new ConsoleHandler();
> handler.setOutputStream(System.out);
Hello Daniel, `ConsoleHandler` doesn't have a (public) method to set the output
stream (i.e. there's no setOutputStream(...)). I decided it wasn't worth it to
create a subclass of ConsoleHandler in these tests just to override and use
System.out. As far as I can see these log messages are merely for debugging.
Do you suggest, I create a custom subclass of ConsoleHandler in these tests?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30158#discussion_r2912408242
