> Can I please get a review of this test-only change which proposes to use > "othervm" for some of these tests that configure java.util.logging logger > handlers? > > As noted in https://bugs.openjdk.org/browse/JDK-8379477 some of these test > definitions don't explicitly require a othervm and thus can interfere with > one another when configuring logging handlers (for the same logger). The > tests themselves don't seem to do anything useful with those loggers or > logging handlers, so the logging configuration could infact be completely > removed. But after discussing about it, we decided to just switch them over > to othervm for now and also use ConsoleHandler in all these tests. > > tier testing completed successfully with this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: add comment explaining othervm usage ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30158/files - new: https://git.openjdk.org/jdk/pull/30158/files/2b2fd13e..6c976cb2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30158&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30158&range=02-03 Stats: 23 lines in 11 files changed: 22 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/30158.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30158/head:pull/30158 PR: https://git.openjdk.org/jdk/pull/30158
