eric-maynard commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2164499086


##########
spec/polaris-management-service.yml:
##########
@@ -911,6 +911,7 @@ components:
             - OAUTH
             - BEARER
             - SIGV4
+            - NO_AUTH

Review Comment:
   In the semver sense, I'm not sure that needs to qualify as a breaking change 
-- at least it hasn't been called out as such when we've made similar changes 
in the past. The REST API is not breaking, even if some clients implemented in 
a fragile way might. Our Python client seems to fail quite gracefully. See 
#1506 and the associated doc 
[here](https://docs.google.com/document/d/1MAW87DtyHWPPNIEkUCRVUKBGjhh5bPn0GbtV7fifm30/edit?tab=t.0#heading=h.v1rcy31tlwav)
 for a similar change made recently.
   
   Separately, if you think it's a good idea to harden our Java client against 
this kind of enum change, I think that would be a great contribution.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to