poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2165045072
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationType.java:
##########
@@ -33,6 +33,7 @@ public enum AuthenticationType {
NULL_TYPE(0),
OAUTH(1),
BEARER(2),
+ NO_AUTH(3),
Review Comment:
From my understanding AuthenticationType (and ConnectionType) should keep
the NULL_TYPE to indicate an unsupported/missing value. Specifically to handle
the case pointed out in the discussion that follows. If a newer version of
AuthenticationType is used to create a federated catalog and the type is
persisted in the ConnectionConfigInfoDPO. Later, an older client tries to read
this DPO, it will return NULL_TYPE; which is an appropriate response
considering it read an unknown/missing type from the DPO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
