dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183482251
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -699,16 +701,10 @@ private Map<String, UserSecretReference>
extractSecretReferences(
/**
* @see #extractSecretReferences
*/
- private boolean requiresSecretReferenceExtraction(CreateCatalogRequest
catalogRequest) {
- Catalog catalog = catalogRequest.getCatalog();
- if (catalog instanceof ExternalCatalog externalCatalog) {
- if (externalCatalog.getConnectionConfigInfo() != null) {
- // TODO: Make this more targeted once we have connection configs that
don't involve
- // processing of inline secrets.
- return true;
- }
- }
- return false;
+ private boolean requiresSecretReferenceExtraction(
+ @NotNull ConnectionConfigInfo connectionConfigInfo) {
+ return
connectionConfigInfo.getAuthenticationParameters().getAuthenticationType()
+ != AuthenticationParameters.AuthenticationTypeEnum.IMPLICIT;
Review Comment:
This will return `true` for `NULL_TYPE`... Is that intended?
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##########
@@ -151,7 +152,8 @@ public void testCreateCatalogSufficientPrivileges() {
@Test
public void testCreateCatalogInsufficientPrivileges() {
- final CatalogEntity newCatalog = new
CatalogEntity.Builder().setName("new_catalog").build();
+ final CatalogEntity newCatalog =
+ new
CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
Review Comment:
Why is this change required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
