poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183698535
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -699,16 +701,10 @@ private Map<String, UserSecretReference>
extractSecretReferences(
/**
* @see #extractSecretReferences
*/
- private boolean requiresSecretReferenceExtraction(CreateCatalogRequest
catalogRequest) {
- Catalog catalog = catalogRequest.getCatalog();
- if (catalog instanceof ExternalCatalog externalCatalog) {
- if (externalCatalog.getConnectionConfigInfo() != null) {
- // TODO: Make this more targeted once we have connection configs that
don't involve
- // processing of inline secrets.
- return true;
- }
- }
- return false;
+ private boolean requiresSecretReferenceExtraction(
+ @NotNull ConnectionConfigInfo connectionConfigInfo) {
+ return
connectionConfigInfo.getAuthenticationParameters().getAuthenticationType()
+ != AuthenticationParameters.AuthenticationTypeEnum.IMPLICIT;
Review Comment:
The type here refers to `AuthenticationTypeEnum` (generated based on the
OpenAPI definition) and not `AuthenticationType` (declared in
`...core.connection.AuthenticationType`). So `AuthenticationTypeEnum` can never
be `NULL_TYPE`, it will be one of the types defined in
polaris-management-service.yml (Line 910 - 914).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
