dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2164510928
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationType.java:
##########
@@ -33,6 +33,7 @@ public enum AuthenticationType {
NULL_TYPE(0),
OAUTH(1),
BEARER(2),
+ NO_AUTH(3),
Review Comment:
I agree that we need to distinguish defined auth from undefined auth (i.e.
`null`). However, a `null` value is not the same as a `NULL_TYPE` value. This
is probably a concern about the existing codebase rather than this particular
PR :thinking: but I did not find any usages of `NULL_TYPE` in the current
codebase.
So, I wonder whether introducing the `NO_AUTH` enum value is really
necessary (as opposed to renaming `NULL_TYPE`). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
