eric-maynard commented on code in PR #1456:
URL: https://github.com/apache/polaris/pull/1456#discussion_r2061023499
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -1843,6 +1845,56 @@ public void
testConcurrencyConflictUpdateTableDuringFinalTransaction() {
.hasMessageContaining("conflict_table");
}
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testTableOperationsDoesNotRefreshAfterCommit(boolean
updateMetadataOnCommit) {
+ Assumptions.assumeTrue(
+ requiresNamespaceCreate(),
Review Comment:
`Assumptions.assumeTrue` is proliferated all through the existing suite, so
if we want to update this we could also do them all at that time
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -1843,6 +1845,56 @@ public void
testConcurrencyConflictUpdateTableDuringFinalTransaction() {
.hasMessageContaining("conflict_table");
}
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testTableOperationsDoesNotRefreshAfterCommit(boolean
updateMetadataOnCommit) {
+ Assumptions.assumeTrue(
+ requiresNamespaceCreate(),
Review Comment:
This `Assumptions.assumeTrue` is proliferated all through the existing
suite, so if we want to update this we could also do them all at that time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
