eric-maynard commented on code in PR #1456:
URL: https://github.com/apache/polaris/pull/1456#discussion_r2060845493
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1577,7 +1605,7 @@ private String newTableMetadataFilePath(TableMetadata
meta, int newVersion) {
* of this code was originally copied from {@link
org.apache.iceberg.view.BaseViewOperations}.
* CODE_COPIED_TO_POLARIS From Apache Iceberg Version: 1.8
*/
- private class BasePolarisViewOperations extends
PolarisOperationsBase<ViewMetadata>
+ public class BasePolarisViewOperations extends
PolarisOperationsBase<ViewMetadata>
Review Comment:
This is public just for parity with `BasePolarisTableOperations`, I can make
it private. `BaseMetastoreOpertations` was a public type though, so it does
seem reasonable just to have them be public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
