RussellSpitzer commented on code in PR #1456:
URL: https://github.com/apache/polaris/pull/1456#discussion_r2060817102
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1476,6 +1492,17 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
+ "because it has been concurrently modified to %s",
tableIdentifier, oldLocation, newLocation, existingLocation);
}
+
+ // We diverge from `BaseMetastoreTableOperations` in the below code block
+ if (updateMetadataOnCommit) {
+ currentMetadata =
+ TableMetadata.buildFrom(metadata)
+ .withMetadataLocation(newLocation)
+ .discardChanges()
+ .build();
+ currentMetadataLocation = newLocation;
Review Comment:
This is great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
