RussellSpitzer commented on code in PR #1456:
URL: https://github.com/apache/polaris/pull/1456#discussion_r2060814462
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -1843,6 +1845,58 @@ public void
testConcurrencyConflictUpdateTableDuringFinalTransaction() {
.hasMessageContaining("conflict_table");
}
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testTableOperationsDoesNotRefreshAfterCommit(boolean
updateMetadataOnCommit) {
+ if (this.requiresNamespaceCreate()) {
+ catalog.createNamespace(NS);
+ }
+
+ catalog.buildTable(TABLE, SCHEMA).create();
+
+ IcebergCatalog.BasePolarisTableOperations realOps =
+ (IcebergCatalog.BasePolarisTableOperations)
+ catalog.newTableOps(TABLE, updateMetadataOnCommit);
+ IcebergCatalog.BasePolarisTableOperations ops = Mockito.spy(realOps);
+
+ try (MockedStatic<TableMetadataParser> mocked =
+ Mockito.mockStatic(TableMetadataParser.class,
Mockito.CALLS_REAL_METHODS)) {
+ TableMetadata base1 = ops.current();
+ mocked.verify(
+ () -> TableMetadataParser.read(Mockito.any(), Mockito.anyString()),
Mockito.times(1));
+
+ TableMetadata base2 = ops.refresh();
+ mocked.verify(
+ () -> TableMetadataParser.read(Mockito.any(), Mockito.anyString()),
Mockito.times(1));
+
+
Assertions.assertThat(base1.metadataFileLocation()).isEqualTo(base2.metadataFileLocation());
+ Assertions.assertThat(base1).isEqualTo(base2);
+
+ Schema newSchema =
+ new Schema(Types.NestedField.optional(100, "new_col",
Types.LongType.get()));
+ TableMetadata newMetadata =
+ TableMetadata.buildFrom(base1).setCurrentSchema(newSchema,
100).build();
+ ops.commit(base2, newMetadata);
+ mocked.verify(
+ () -> TableMetadataParser.read(Mockito.any(), Mockito.anyString()),
Mockito.times(1));
+
+ ops.current();
+ int expectedReads = 2;
Review Comment:
minor personal nit, but I think a ternary assignment here is a little
clearer than the branch and overwrite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
