eric-maynard commented on code in PR #1456:
URL: https://github.com/apache/polaris/pull/1456#discussion_r2061006596
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -59,4 +59,14 @@ protected BehaviorChangeConfiguration(
.description("Whether or not to use soft values in the entity cache")
.defaultValue(false)
.buildBehaviorChangeConfiguration();
+
+ public static final BehaviorChangeConfiguration<Boolean>
TABLE_OPERATIONS_COMMIT_UPDATE_METADATA =
+ PolarisConfiguration.<Boolean>builder()
+ .key("TABLE_OPERATIONS_COMMIT_UPDATE_METADATA")
+ .description(
+ "If true, BasePolarisTableOperations should update the metadata
that is passed into"
+ + " `commit`, and re-use it to skip a trip to object storage
to re-construct"
+ + " the committed metadata again.")
Review Comment:
This is a `BehaviorChangeConfiguration`, so it's really a break-glass config
that users are explicitly cautioned against using. It's there to protect the
service from regressions, and it's intended to be removed after we determine
that the default is stable. I wouldn't expect a user to know what `Whether or
not to use soft values in the entity cache` means, either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
