dimas-b commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2053048269
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -133,7 +133,7 @@ void deleteFromEntities(EntityManager session, long
catalogId, long entityId) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, catalogId, entityId);
+ ModelEntity model = lookupEntity(session, catalogId, entityId, -1);
Review Comment:
These type codes were added from the WIP NoSQL implementation. In that code,
entities are segregated by type in many cases. I do not think the NoSQL impl.
does a "fan-out" search to delete entities having different type codes.
I tend to regard this type code parameter as having to reflect the correct
actual type of the entity whose ID is passed as another parameter. Providing
correct values is the responsibility of the caller.
If we want to change that aspect (and I'm open to discussing that), I'm not
sure type codes will be helpful to the NoSQL impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
