eric-maynard commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2050871447
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -84,7 +84,7 @@ void writeToEntities(EntityManager session, PolarisBaseEntity
entity) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId());
+ ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId(), -1);
Review Comment:
Should we use NULL_TYPE here? Some new construct like UNKNOWN_TYPE /
ANY_TYPE? Make the type argument Optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
