adutra commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2051473228
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -133,7 +133,7 @@ void deleteFromEntities(EntityManager session, long
catalogId, long entityId) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, catalogId, entityId);
+ ModelEntity model = lookupEntity(session, catalogId, entityId, -1);
Review Comment:
Again, I'm not sure it makes sense on write paths. The idea here, as I
interpret it, is to delete the entity with a given id, regardless of its type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
