eric-maynard commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2050883885
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -84,7 +84,7 @@ void writeToEntities(EntityManager session, PolarisBaseEntity
entity) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId());
+ ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId(), -1);
Review Comment:
I will admit I assumed that, but I had to go check to make sure -1 is not a
real code :)
I thought one of the other constructs might be safer. We could even keep -1
and just call it ANY_TYPE. Anyway, let's see what others think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
