eric-maynard commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2051174368
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -84,7 +84,7 @@ void writeToEntities(EntityManager session, PolarisBaseEntity
entity) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId());
+ ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId(), -1);
Review Comment:
+1 to using that if it's applicable. My comment is more about what we should
do in the case that we _don't_ want to filter by type code, or we don't have a
type code available. -1 seems like an okay way to represent this but I wanted
to explore alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
