collado-mike commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2047857076
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {
super(original);
}
+ public Builder setFederated(Boolean isFederated) {
+ if (isFederated != null && isFederated) {
Review Comment:
I'm saying the code example you suggested is a programming error. Ideally,
that would be handled by the compiler, but an exception would also work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
