dimas-b commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2047877788
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {
super(original);
}
+ public Builder setFederated(Boolean isFederated) {
+ if (isFederated != null && isFederated) {
Review Comment:
I support @eric-maynard 's point here. Current code is very risky in terms
of latent bug, IMHO. A caller of `.setFederated(false)` can reasonably expect
the property to become `false` regardless of any previous `set*` calls (which
might have been made in a different context).
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {
super(original);
}
+ public Builder setFederated(Boolean isFederated) {
+ if (isFederated != null && isFederated) {
Review Comment:
I support @eric-maynard 's point here. Current code is very risky in terms
of latent bugs, IMHO. A caller of `.setFederated(false)` can reasonably expect
the property to become `false` regardless of any previous `set*` calls (which
might have been made in a different context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
