collado-mike commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2045057068
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {
super(original);
}
+ public Builder setFederated(Boolean isFederated) {
+ if (isFederated != null && isFederated) {
Review Comment:
Yeah, the idea is to avoid adding any entry for non-federated identities. I
don't think the logic snippet you posted is reasonable or should be supported.
I'd be in favor of an IllegalStateException if someone typed that code. Happy
to add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
