dimas-b commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2067146918
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java:
##########
@@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {
super(original);
}
+ public Builder setFederated(Boolean isFederated) {
+ if (isFederated != null && isFederated) {
Review Comment:
@collado-mike : this is the only substantial issue with the current state if
this PR from my POV.
The other topics got clarified in ML and doc comments, I think the PR is
good to merge after we resolve the setter issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
