collado-mike commented on code in PR #1353:
URL: https://github.com/apache/polaris/pull/1353#discussion_r2045079760
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java:
##########
@@ -871,6 +873,42 @@ public void testCreatePrincipalAndRotateCredentials() {
// rotation that makes the old secret fall off retention.
}
+ @Test
+ public void testCreateFederatedPrincipalFails() {
Review Comment:
External catalog has a separate type because it has an extra field.
Federated identity types don't have any additional fields at this point, so I'd
prefer not to add an extra type. If extra fields end up getting added, then it
would make sense, but for now deserializing wouldn't even be able to
distinguish what type it should deserialized to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
