HonahX commented on code in PR #1264:
URL: https://github.com/apache/polaris/pull/1264#discussion_r2023673228
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/table/GenericTableEntity.java:
##########
@@ -52,6 +53,11 @@ public String getFormat() {
return getInternalPropertiesAsMap().get(GenericTableEntity.FORMAT_KEY);
}
+ @JsonIgnore
+ public String getDoc() {
Review Comment:
[Non-blocking question] Just to confirm my understanding, we reserve
"properties" for generic table's location, connection info, etc, so we put
other information like format and doc in the internalProperties? Do we have any
convention like things in the internal properties should not expose to users?
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GenericTableCatalogHandlerWrapperAuthzTest.java:
##########
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.quarkus.catalog;
+
+import io.quarkus.test.junit.QuarkusTest;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.polaris.core.auth.AuthenticatedPolarisPrincipal;
+import org.apache.polaris.core.entity.PolarisPrivilege;
+import
org.apache.polaris.service.catalog.generic.GenericTableCatalogHandlerWrapper;
+import org.apache.polaris.service.quarkus.admin.PolarisAuthzTestBase;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+@QuarkusTest
+public class GenericTableCatalogHandlerWrapperAuthzTest extends
PolarisAuthzTestBase {
+
+ private GenericTableCatalogHandlerWrapper newWrapper() {
+ return newWrapper(Set.of());
+ }
+
+ private GenericTableCatalogHandlerWrapper newWrapper(Set<String>
activatedPrincipalRoles) {
+ return newWrapper(activatedPrincipalRoles, CATALOG_NAME);
+ }
+
+ private GenericTableCatalogHandlerWrapper newWrapper(
+ Set<String> activatedPrincipalRoles, String catalogName) {
+ final AuthenticatedPolarisPrincipal authenticatedPrincipal =
+ new AuthenticatedPolarisPrincipal(principalEntity,
activatedPrincipalRoles);
+ return new GenericTableCatalogHandlerWrapper(
+ callContext,
+ entityManager,
+ metaStoreManager,
+ securityContext(authenticatedPrincipal, activatedPrincipalRoles),
+ catalogName,
+ polarisAuthorizer);
+ }
+
+ /**
+ * Tests each "sufficient" privilege individually using CATALOG_ROLE1 by
granting at the
+ * CATALOG_NAME level, revoking after each test, and also ensuring that the
request fails after
+ * revocation.
+ *
+ * @param sufficientPrivileges List of privileges that should be sufficient
each in isolation for
+ * {@code action} to succeed.
+ * @param action The operation being tested; could also be multiple
operations that should all
+ * succeed with the sufficient privilege
+ * @param cleanupAction If non-null, additional action to run to "undo" a
previous success action
+ * in case the action has side effects. Called before revoking the
sufficient privilege;
+ * either the cleanup privileges must be latent, or the cleanup action
could be run with
+ * PRINCIPAL_ROLE2 while runnint {@code action} with PRINCIPAL_ROLE1.
+ */
+ private void doTestSufficientPrivileges(
+ List<PolarisPrivilege> sufficientPrivileges, Runnable action, Runnable
cleanupAction) {
+ doTestSufficientPrivilegeSets(
+ sufficientPrivileges.stream().map(priv -> Set.of(priv)).toList(),
+ action,
+ cleanupAction,
+ PRINCIPAL_NAME);
+ }
+
+ /**
+ * @param sufficientPrivileges each set of concurrent privileges expected to
be sufficient
+ * together.
+ * @param action
+ * @param cleanupAction
+ * @param principalName
+ */
+ private void doTestSufficientPrivilegeSets(
Review Comment:
These helpers seems identical/similar to ones in
IcebergCatalogHandlerWrapperAuthzTest. Probably in a follow-up PR, shall we
consider extracting these to testBase or some util classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
