eric-maynard commented on code in PR #1264:
URL: https://github.com/apache/polaris/pull/1264#discussion_r2023771958
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##########
@@ -162,7 +208,7 @@ public enum PolarisPrivilege {
private final PolarisEntityType securableType;
// the subtype of the securable for this privilege
- private final PolarisEntitySubType securableSubType;
+ private final List<PolarisEntitySubType> securableSubTypes;
Review Comment:
Yun expressed a concern about us not updating these types in a previous PR
and I think it's still valid. Even if the `securableSubType` is not enforced,
we should probably update it to reflect how we want these grants to be used.
Otherwise, we could just yank `securableSubType` out of the current code
altogether.
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/table/GenericTableEntity.java:
##########
@@ -35,6 +35,7 @@
public class GenericTableEntity extends TableLikeEntity {
public static final String FORMAT_KEY = "format";
+ public static final String DOC_KEY = "doc";
Review Comment:
The spec calls this field `doc`, otherwise I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
