eric-maynard commented on code in PR #1264:
URL: https://github.com/apache/polaris/pull/1264#discussion_r2023771958
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##########
@@ -162,7 +208,7 @@ public enum PolarisPrivilege {
private final PolarisEntityType securableType;
// the subtype of the securable for this privilege
- private final PolarisEntitySubType securableSubType;
+ private final List<PolarisEntitySubType> securableSubTypes;
Review Comment:
Yun expressed this concern in a previous PR and I think it's valid. Even if
the `securableSubType` is not enforced, we should probably update it to reflect
how we want these grants to be used. Otherwise, we could just yank
`securableSubType` out of the current code altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
