gh-yzou commented on code in PR #1264:
URL: https://github.com/apache/polaris/pull/1264#discussion_r2023774331
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/table/GenericTableEntity.java:
##########
@@ -35,6 +35,7 @@
public class GenericTableEntity extends TableLikeEntity {
public static final String FORMAT_KEY = "format";
+ public static final String DOC_KEY = "doc";
Review Comment:
The "doc" is used as the API field, to keep things consistent, how about
let's just keep it as doc. I was using doc since it was some term used in
iceberg
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L2079.
i was originally intended to use name "comment", it was a more commonly used
name in other table catalog like unity and gravitino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
