eric-maynard commented on code in PR #1264:
URL: https://github.com/apache/polaris/pull/1264#discussion_r2017820807
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalogAdapter.java:
##########
@@ -19,7 +19,52 @@
package org.apache.polaris.service.catalog.generic;
import jakarta.enterprise.context.RequestScoped;
+import jakarta.ws.rs.core.Response;
+import jakarta.ws.rs.core.SecurityContext;
+import org.apache.polaris.core.context.RealmContext;
import
org.apache.polaris.service.catalog.api.PolarisCatalogGenericTableApiService;
+import org.apache.polaris.service.types.CreateGenericTableRequest;
@RequestScoped
-public class GenericTableCatalogAdapter implements
PolarisCatalogGenericTableApiService {}
+public class GenericTableCatalogAdapter implements
PolarisCatalogGenericTableApiService {
+ @Override
+ public Response createGenericTable(
+ String prefix,
+ String namespace,
+ CreateGenericTableRequest createGenericTableRequest,
+ RealmContext realmContext,
+ SecurityContext securityContext) {
+ return Response.status(501).build(); // not implemented
Review Comment:
Prior to #1263 this was needed in order for everything to build; now it
could be omitted but it's a functional no-op and the implementation to follow
will need this code anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
