gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4040498569
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + ref: ${{ matrix.branch }} + persist-credentials: false + + - uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1 + with: + java-version: '21' + distribution: 'temurin' + cache: maven + + - name: Update lifecycle plugin versions + run: | + mvn -B versions:update-properties \ + -Pversions-update \ + -DallowMajorUpdates=false \ + -DincludeProperties="version.maven-clean-plugin,version.maven-compiler-plugin,version.maven-deploy-plugin,version.maven-ear-plugin,version.maven-ejb-plugin,version.maven-install-plugin,version.maven-jar-plugin,version.maven-plugin-plugin,version.maven-rar-plugin,version.maven-resources-plugin,version.maven-site-plugin,version.maven-surefire-plugin,version.maven-war-plugin" \ + -pl impl/maven-core + + - name: Create Pull Request + env: + GH_TOKEN: ${{ github.token }} + BRANCH: update/lifecycle-plugins-${{ matrix.branch }} + BASE_BRANCH: ${{ matrix.branch }} + run: | + if git diff --quiet impl/maven-core/pom.xml; then + echo "No lifecycle plugin version changes detected." + exit 0 Review Comment: ⚠️ **Regression: `github.token` re-introduced — PRs it creates won't trigger CI.** Commit `9c41c1ad` correctly switched to `secrets.GH_TOKEN` to work around the GitHub limitation that PRs opened by the built-in token do not trigger `on: pull_request` workflows. That fix was lost when `peter-evans/create-pull-request` was replaced — `github.token` is back. The update PRs will have no `Java CI` checks. ```suggestion GH_TOKEN: ${{ secrets.GH_TOKEN }} ``` ########## pom.xml: ########## @@ -1302,5 +1302,154 @@ under the License. </plugins> </build> </profile> + <profile> + <!-- + This profile is NEVER activated during a normal build. + It configures versions-maven-plugin to map the version.maven-*-plugin + properties (in impl/maven-core/pom.xml) to their corresponding Maven + plugin artifacts, enabling: + + mvn versions:update-properties -Pversions-update \ + -DincludeProperties="version.maven-clean-plugin,..." \ + -pl impl/maven-core + + The GitHub Actions workflow .github/workflows/update-lifecycle-plugins.yml + runs this command weekly and opens a PR when updates are found. + --> + <id>versions-update</id> + <build> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>versions-maven-plugin</artifactId> + <version>2.18.0</version> Review Comment: 💡 **`versions-maven-plugin` is outdated — `2.22.0` is available on Maven Central** (four releases since `2.18.0`). This was flagged by @slawekjaranowski and not yet addressed. ```suggestion <version>2.22.0</version> ``` ########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + ref: ${{ matrix.branch }} + persist-credentials: false + + - uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1 + with: + java-version: '21' + distribution: 'temurin' + cache: maven + + - name: Update lifecycle plugin versions + run: | + mvn -B versions:update-properties \ + -Pversions-update \ + -DallowMajorUpdates=false \ + -DincludeProperties="version.maven-clean-plugin,version.maven-compiler-plugin,version.maven-deploy-plugin,version.maven-ear-plugin,version.maven-ejb-plugin,version.maven-install-plugin,version.maven-jar-plugin,version.maven-plugin-plugin,version.maven-rar-plugin,version.maven-resources-plugin,version.maven-site-plugin,version.maven-surefire-plugin,version.maven-war-plugin" \ + -pl impl/maven-core + + - name: Create Pull Request + env: + GH_TOKEN: ${{ github.token }} + BRANCH: update/lifecycle-plugins-${{ matrix.branch }} + BASE_BRANCH: ${{ matrix.branch }} Review Comment: 💡 **`-DincludeProperties` should move into the profile config, not the CLI.** @slawekjaranowski asked why it's not in the profile. `<includeProperties>` is a valid POM configuration parameter for `versions-maven-plugin` — adding it to the `versions-update` profile in `pom.xml` would make the profile fully self-contained and simplify the workflow command to: ``` mvn -B versions:update-properties -Pversions-update -pl impl/maven-core ``` The profile's own comment even shows the `-DincludeProperties` flag but doesn't deliver it as config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
