AlexanderAshitkin commented on code in PR #181:
URL:
https://github.com/apache/maven-build-cache-extension/pull/181#discussion_r1734749461
##########
src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java:
##########
@@ -81,7 +82,7 @@ private Model normalizedModelInner(MavenProject project) {
// does not make sense to add project version to calculate hash
resultModel.setVersion(NORMALIZED_VERSION);
resultModel.setModules(prototype.getModules());
-
+
resultModel.setProperties(normalizeProperties(prototype.getProperties()));
Review Comment:
The statement above is applicable to "input" properties which are majority
of parameters. For output properties (for example - new `generated-source`
directory added to the cache) this change looks legit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
