AlexanderAshitkin commented on code in PR #181:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/181#discussion_r1732884332


##########
src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java:
##########
@@ -81,7 +82,7 @@ private Model normalizedModelInner(MavenProject project) {
         // does not make sense to add project version to calculate hash
         resultModel.setVersion(NORMALIZED_VERSION);
         resultModel.setModules(prototype.getModules());
-
+        
resultModel.setProperties(normalizeProperties(prototype.getProperties()));

Review Comment:
   Please elaborate on the initial problem. Is the concern that after changing 
the properties, a different artifact is expected to be cached? The properties 
are intentionally not added to the checksum.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to