reda-alaoui commented on code in PR #181: URL: https://github.com/apache/maven-build-cache-extension/pull/181#discussion_r1734256032
########## src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java: ########## @@ -81,7 +82,7 @@ private Model normalizedModelInner(MavenProject project) { // does not make sense to add project version to calculate hash resultModel.setVersion(NORMALIZED_VERSION); resultModel.setModules(prototype.getModules()); - + resultModel.setProperties(normalizeProperties(prototype.getProperties())); Review Comment: @AlexanderAshitkin , maybe you missed the initial problem description that was available in https://issues.apache.org/jira/browse/MBUILDCACHE-107: > Changing a pom.xml property like `maven.build.cache.exclude.glob.1` does not impact the input checksum and therefore keeps using the wrong cache entry. The only remediation is to remove the cache entry manually. Tell me if it makes sense to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org