gnodet commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1672709032
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java:
##########
@@ -26,18 +26,18 @@
import java.util.Properties;
import java.util.TimeZone;
+import org.apache.maven.api.Constants;
+
/**
* MavenBuildTimestamp
*/
public class MavenBuildTimestamp {
// ISO 8601-compliant timestamp for machine readability
- public static final String DEFAULT_BUILD_TIMESTAMP_FORMAT =
"yyyy-MM-dd'T'HH:mm:ss'Z'";
-
- public static final String BUILD_TIMESTAMP_FORMAT_PROPERTY =
"maven.build.timestamp.format";
+ public static final String DEFAULT_BUILD_TIMESTAMP_FORMAT =
"yyyy-MM-dd'T'HH:mm:ssXXX";
Review Comment:
`Constants.MAVEN_BUILD_TIMESTAMP_FORMAT` defines the property name. The
default value is available on the `@Config` annotation, but at this point, it
is for documentation only.
Another way would be to move the default values as constants, i.e. move
DEFAULT_BUILD_TIMESTAMP_FORMAT to `Constants` and link both there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
