michael-o commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1672416637
##########
apache-maven/src/assembly/maven/conf/maven.properties:
##########
@@ -0,0 +1,40 @@
+#
+# Maven user properties
+#
+
+maven.installation.conf = ${maven.home}/conf
+maven.user.conf = ${user.home}/.m2
+maven.project.conf = ${session.rootDirectory}/.mvn
+
+# Comma-separated list of files to include.
+# Each item may be enclosed in quotes to gracefully include spaces. Items are
trimmed before being loaded.
+# If the first character of an item is a question mark, the load will silently
fail if the file does not exist.
+${includes} = "?${maven.user.conf}/maven.properties", \
Review Comment:
Since you are quoting now the value, wouldn't it be more natural to put the
question mark at the end? Unless you want to use "¿" as well. Maybe qoutes
should be mandatory. Worth looking into Tomcat code for ths. I do not remember
the motiviation.
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java:
##########
@@ -26,18 +26,18 @@
import java.util.Properties;
import java.util.TimeZone;
+import org.apache.maven.api.Constants;
+
/**
* MavenBuildTimestamp
*/
public class MavenBuildTimestamp {
// ISO 8601-compliant timestamp for machine readability
- public static final String DEFAULT_BUILD_TIMESTAMP_FORMAT =
"yyyy-MM-dd'T'HH:mm:ss'Z'";
-
- public static final String BUILD_TIMESTAMP_FORMAT_PROPERTY =
"maven.build.timestamp.format";
+ public static final String DEFAULT_BUILD_TIMESTAMP_FORMAT =
"yyyy-MM-dd'T'HH:mm:ssXXX";
Review Comment:
Why not use `Constants.MAVEN_BUILD_TIMESTAMP_FORMAT` instead of a literal
again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
