michael-o commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1672113492
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##########
@@ -57,13 +57,13 @@ public class DefaultToolchainsBuilder implements
ToolchainsBuilder {
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException {
List<BuilderProblem> problems = new ArrayList<>();
- Source globalSource = request.getGlobalToolchainsSource().orElse(null);
- PersistedToolchains global = readToolchains(globalSource, request,
problems);
+ Source installSource =
request.getInstallationToolchainsSource().orElse(null);
Review Comment:
Same here
##########
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -358,10 +359,7 @@ public void close() {
private int getParallelism(ProjectBuildingRequest request) {
int parallelism = DEFAULT_BUILDER_PARALLELISM;
try {
- String str =
request.getUserProperties().getProperty(BUILDER_PARALLELISM);
- if (str == null) {
- str =
request.getSystemProperties().getProperty(BUILDER_PARALLELISM);
- }
+ String str =
request.getUserProperties().getProperty(Constants.MAVEN_PROJECT_BUILDER_PARALLELISM);
Review Comment:
Very good, less dependence on system properties
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java:
##########
@@ -70,7 +67,6 @@ public MavenBuildTimestamp(Instant time, String
timestampFormat) {
}
SimpleDateFormat dateFormat = new SimpleDateFormat(timestampFormat);
dateFormat.setCalendar(new GregorianCalendar());
- dateFormat.setTimeZone(DEFAULT_BUILD_TIME_ZONE);
Review Comment:
Attention, this is a semantic change. We should retain `Etc/UTC` and maybe
make it configurable in the future.
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultSettingsBuilder.java:
##########
@@ -66,8 +66,8 @@ public class DefaultSettingsBuilder implements
SettingsBuilder {
public SettingsBuilderResult build(SettingsBuilderRequest request) throws
SettingsBuilderException {
List<BuilderProblem> problems = new ArrayList<>();
- Source globalSource = request.getGlobalSettingsSource().orElse(null);
- Settings global = readSettings(globalSource, false, request, problems);
+ Source installSource =
request.getInstallationSettingsSource().orElse(null);
Review Comment:
`installationSource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
