gnodet commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1672705329
########## apache-maven/src/assembly/maven/conf/maven.properties: ########## @@ -0,0 +1,40 @@ +# +# Maven user properties +# + +maven.installation.conf = ${maven.home}/conf +maven.user.conf = ${user.home}/.m2 +maven.project.conf = ${session.rootDirectory}/.mvn + +# Comma-separated list of files to include. +# Each item may be enclosed in quotes to gracefully include spaces. Items are trimmed before being loaded. +# If the first character of an item is a question mark, the load will silently fail if the file does not exist. +${includes} = "?${maven.user.conf}/maven.properties", \ Review Comment: I'm not sure quotes are mandatory, but they certainly avoid any problem with spaces inside path. About the location of the '?', I fear that putting it at end will be less prominent. It's also the same syntax than for optional profiles, see https://maven.apache.org/guides/introduction/introduction-to-profiles.html#explicit-profile-activation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org