michael-o commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1672220076
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java:
##########
@@ -70,7 +67,6 @@ public MavenBuildTimestamp(Instant time, String
timestampFormat) {
}
SimpleDateFormat dateFormat = new SimpleDateFormat(timestampFormat);
dateFormat.setCalendar(new GregorianCalendar());
- dateFormat.setTimeZone(DEFAULT_BUILD_TIME_ZONE);
Review Comment:
Without setting the timezone it will use the local timezone. It won't be
reproducible for those crossing time zones. If you set the timezone `XXX` will
produce stable output, with `Etc/UTC` always `Z`. Then if we say that the
timezone can be configured `XXX` will produce proper output, `'Z'` is just a
static literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
