gnodet commented on code in PR #1597:
URL: https://github.com/apache/maven/pull/1597#discussion_r1670970794


##########
apache-maven/src/assembly/maven/conf/settings.xml:
##########
@@ -29,14 +29,14 @@ under the License.
  |
  |                 -s /path/to/user/settings.xml
  |
- |  2. Global Level. This settings.xml file provides configuration for all 
Maven
+ |  2. System Level. This settings.xml file provides configuration for all 
Maven

Review Comment:
   Even better, we can use the following:
   ```
   maven.install.toolchains = 
${cli:it:-${cli:gt:-${maven.install.conf}/toolchains.xml}}
   maven.project.toolchains = ${maven.project.conf}/toolchains.xml
   maven.user.toolchains    = ${cli:t:-${maven.user.conf}/toolchains.xml}
   maven.toolchains = ?${maven.install.toolchains} \
                      ?${maven.project.toolchains} \
                      ?${maven.user.toolchains}
   ```
   
   The `:-` is used to specify a default value, and `${cli:t}` will grab the 
value of the `-t` CLI flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to