gnodet commented on code in PR #1597:
URL: https://github.com/apache/maven/pull/1597#discussion_r1671307588
##########
apache-maven/src/assembly/maven/conf/settings.xml:
##########
@@ -29,14 +29,14 @@ under the License.
|
| -s /path/to/user/settings.xml
|
- | 2. Global Level. This settings.xml file provides configuration for all
Maven
+ | 2. System Level. This settings.xml file provides configuration for all
Maven
Review Comment:
Actually, we may still need the `?`. Currently, if you specify `-t
foo.xml`, maven will fail if `foo.xml` file does not exist. Whereas _default_
files can be safely ignored if they don't exist. So we need to be able to know
if a file was explicitely specified or just defaulted imho. So maybe:
```
maven.user.toolchains = ${cli:t:-?${maven.user.toolchains.default}}
```
Note that we could use `cli.t` instead of `cli:t`, this may be less
confusing:
```
maven.user.toolchains = ${cli.t:-?${maven.user.toolchains.default}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
