michael-o commented on code in PR #1597: URL: https://github.com/apache/maven/pull/1597#discussion_r1671017546
########## apache-maven/src/assembly/maven/conf/settings.xml: ########## @@ -29,14 +29,14 @@ under the License. | | -s /path/to/user/settings.xml | - | 2. Global Level. This settings.xml file provides configuration for all Maven + | 2. System Level. This settings.xml file provides configuration for all Maven Review Comment: @gnodet What I like is you are picking up the idea of https://github.com/apache/tomcat/blob/main/conf/catalina.properties#L33. Honestly, I cannot decipher it: `${cli:it:-${cli:gt:-${maven.install.conf}/toolchains.xml}}` Takes too much brain muscles from first glance. I wonder why those XML files cannot be optional by default and Maven would simply iterate over ``` ?${maven.install.extensions} \ ?${maven.project.extensions} \ ?${maven.user.extensions} ``` At the end we define the semantics how a property is interpreted. Git or Subversion do search for a user and global config and it is not a failure if both isn't there. Same here. We could log the absence at debug level. WDYT? This would make the `?` redudant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
