gnodet commented on code in PR #1597:
URL: https://github.com/apache/maven/pull/1597#discussion_r1671300209
##########
apache-maven/src/assembly/maven/conf/settings.xml:
##########
@@ -29,14 +29,14 @@ under the License.
|
| -s /path/to/user/settings.xml
|
- | 2. Global Level. This settings.xml file provides configuration for all
Maven
+ | 2. System Level. This settings.xml file provides configuration for all
Maven
Review Comment:
I'm fine with removing the `?` and assuming all those files are optional.
But that does not address CLI parameters. Right now, they are supported by
dedicated code in MavenCli. The code would check if `-t` is set, and set the
user toolchain file accordingly, else compute the default. It's one OR is the
other, not both. So we need a way to have default values in the syntax, that's
what the following would do:
```
maven.user.toolchains.default = ${maven.user.conf}/toolchains.xml}
maven.user.toolchains = ${cli:t:-${maven.user.toolchains.default}}
maven.toolchains = ${maven.install.toolchains} \
${maven.project.toolchains} \
${maven.user.toolchains}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
