[ 
https://issues.apache.org/jira/browse/MNG-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825022#comment-17825022
 ] 

ASF GitHub Bot commented on MNG-8072:
-------------------------------------

rmannibucau commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987170365

   > You should not assume maven-core(-plugins) inability to adapt to never 
features to everyone, e.g. Tycho always uses latest maven and latest features
   
   I didn't at all, even the opposite if you read carefully. I just highlight 
you create a concurrent feature of something existing in latest version of the 
project - indeed it needs a few adjustment but it does not need the proposed PR.
   
   > "by default" Maven can't know what is desired for a consumer pom
   
   Then you don't speak about consumer pom which is well defined as a 
consummable pom by downstream builds (v4.0.0), anything else is not consumer 
pom and does not belong to core IMO - I suspect even if not sure you want some 
tycho meta but this is not about consumer pom IMHO, potentially main pom but 
consumer has another intent.
   
   >  I can't see how maven could ever handle this automatically given that..
   
   Consumer pom is built form the model, if you fill the model you get a valid 
consumer pom.
   
   > where current solution has undesired side-effect and only looks at 
project.getFile()
   
   In maven 3 there isnt really a notion of consumer pom (we had some proto but 
no real API) so it is mainly about a single v4.0.0 pom you were able to mutate. 
Indeed it has side effects but similarly your consumer pom will have exactly 
the same since it has the exact same design and all plugins will not always 
agree on that (current pitfall).
   This is why it is important to use the model IMHO and let the tranformer 
create a valid shareable and backward compat consumer pom.




> Add a consumerPomFile to the MavenProject
> -----------------------------------------
>
>                 Key: MNG-8072
>                 URL: https://issues.apache.org/jira/browse/MNG-8072
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently there is some vague definition of a "build pom" versus a "consumer 
> pom":
> * https://maven.apache.org/studies/consumer-pom/
> * https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
> there are also some plugins around to work with this e.g.
> * 
> https://tycho.eclipseprojects.io/doc/latest/tycho-packaging-plugin/update-consumer-pom-mojo.html
> * https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html
> but there are some issues:
> # Maven makes some assumptions about its "file", e.g setting the file changes 
> the basedir
> # Even though there is a setPomFile method that do not change the basedir 
> e.g. a parent ref by default would be broken
> # once we change the file, there is a mismatch between the pom on disk and 
> the model
> # it is not possible for a plugin to know the original file and the consumer 
> file, e.g. if I want to deploy the original file e.g. with classifier 
> "pom-build"
> # because of this usually "consumer pom plugins" generate the the new pom to 
> a new file in the project root, where it actually not belongs to and leaves 
> the file even after mvn clean if no special actions are taken.
> I therefore like to suggest to enhance the MavenProject with one more method 
> set/getConsumerPom that fills this gap, then plugins working on the consumer 
> pom can set the file there and e.g. 
> https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html can 
> look there first, or even have an option to deploy both poms automatically if 
> they differ.
> Of course this will be nothing happen right now but looks like something that 
> can become useful over time and maybe fully adapted in Maven4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to